Skip to content

Move manifest comparison part to provider package to be reusable #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 1 commit into from
Jul 5, 2021
Merged

Move manifest comparison part to provider package to be reusable #2174

pipecd-bot merged 1 commit into from
Jul 5, 2021

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jul 5, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 5, 2021

COVERAGE

Code coverage for golang is 32.77%. This pull request increases coverage by 0.35%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/kubernetes/diff.go DiffListResult.NoChange -- 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/diff.go Diff -- 100.00% +100.00%
pkg/app/piped/cloudprovider/kubernetes/diff.go DiffList -- 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/diff.go DiffListResult.DiffString -- 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/diff.go groupManifests -- 92.00% +92.00%
pkg/app/piped/cloudprovider/kubernetes/manifest.go Diff 100.00% -- -100.00%
pkg/app/piped/driftdetector/kubernetes/detector.go NewDetector 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go detector.Run 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go detector.check 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go detector.checkApplication 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go detector.loadHeadManifests 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go detector.listGroupedApplication 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go detector.loadDeploymentConfiguration 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go detector.ProviderName 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go groupManifests 92.00% -- -92.00%
pkg/app/piped/driftdetector/kubernetes/detector.go makeSyncedState 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go makeOutOfSyncState 0.00% -- +-0.00%
pkg/app/piped/driftdetector/kubernetes/detector.go filterIgnoringManifests 0.00% -- +-0.00%

@khanhtc1202
Copy link
Member

khanhtc1202 commented Jul 5, 2021

/lgtm
nit, instead of move xxx out of yyy using move xxx to zzz may better for understand what this PR addressed 👍

@pipecd-bot pipecd-bot added the lgtm label Jul 5, 2021
@nghialv nghialv changed the title Move manifest comparison part out of drift detector package to be reusable Move manifest comparison part to provider package to be reusable Jul 5, 2021
@nakabonne
Copy link
Member

nakabonne commented Jul 5, 2021

👍
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 5, 2021

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 00db316 into master Jul 5, 2021
@pipecd-bot pipecd-bot deleted the drift-detector branch July 5, 2021 02:03
@pipecd-bot pipecd-bot mentioned this pull request Jul 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

@nakabonne nakabonne Awaiting requested review from nakabonne

Assignees

No one assigned

Labels

approved area/piped lgtm release-note-none size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nghialv @pipecd-bot @khanhtc1202 @nakabonne